Skip to content

Dark App Launcher Tiles#2294

Merged
minacode merged 11 commits into
InfiniTimeOrg:mainfrom
InfiniBros:dark_tiles
Jun 29, 2025
Merged

Dark App Launcher Tiles#2294
minacode merged 11 commits into
InfiniTimeOrg:mainfrom
InfiniBros:dark_tiles

Conversation

@tituscmd

Copy link
Copy Markdown
Contributor

This is a simple PR to replace the aqua colored tiles in the app launcher with darker ones, going hand-in-hand with my #2292
This is most likely just up to taste, but I thought the cyan tiles were outdated since that color isn't used anywhere else, so I thought a darker color would match the current system theme better.

Let me know what you think!

image
image
image

@tituscmd tituscmd changed the title Dark tiles Dark App Launcher Tiles May 12, 2025
@github-actions

github-actions Bot commented May 12, 2025

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 378980B -16B
data 944B 0B
bss 22536B 0B

Run in InfiniEmu

@liamcharger

Copy link
Copy Markdown
Contributor

The issue I see with this is it's a matter of preference: some people may prefer the aqua, and some may prefer this gray.

I'm not sure if this would align with the vision, but a setting to change the theme would be nice, with options for the original color, this gray, maybe a red, and so on.

@mark9064

Copy link
Copy Markdown
Member

I think we'd probably want to stick to one theme, as supporting multiple adds some extra overhead from a code maintenance perspective.

I think it's nice that the colours are synchronised, though I don't feel super strongly

Comment thread src/displayapp/screens/Tile.cpp Outdated
@mark9064 mark9064 added the UI/UX User interface/User experience label May 12, 2025
@mmind

mmind commented May 27, 2025

Copy link
Copy Markdown

As I found out in #2301 , the application launcher does track an enabled state for the app icons (for when the resources are missing for example).

So nothing against changing the color, just mentioning that is should probably still allow seeing a disabled app icon.

@mark9064

Copy link
Copy Markdown
Member

@JF002 Any chance you can chime in, I got interested in InfiniTime long after this colour was chosen so wondering if there's any history here (and therefore maybe reasons to change/not to change it)

@JF002

JF002 commented May 31, 2025

Copy link
Copy Markdown
Collaborator

I'm not sure I remember how this specific color was chosen, to be honest. We used to have maintainers who took care of the UI (themes, colors, layout,..) but they are not around anymore.
I think there's no reason not to change it, especially if it improves the user experience and consistency between all InfiniTime applications.

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM to me then :)

@mark9064 mark9064 added this to the 1.16.0 milestone Jun 17, 2025
@minacode

Copy link
Copy Markdown
Contributor

I agree that using the theme here is the correct way to go. Changing the theme would be another discussion.

@minacode minacode merged commit 250e7a7 into InfiniTimeOrg:main Jun 29, 2025
7 checks passed
@minacode

Copy link
Copy Markdown
Contributor

Thank you! 🙂

@tituscmd

Copy link
Copy Markdown
Contributor Author

Thank you! 🙂

You're very welcome! :)

JustScott pushed a commit to JustScott/InfiniTime that referenced this pull request Jul 29, 2025
tmaklin pushed a commit to tmaklin/InfiniTime that referenced this pull request Jul 31, 2025
metaphys pushed a commit to metaphys/InfiniTime that referenced this pull request Mar 30, 2026
iakat pushed a commit to iakat/InfiniTime that referenced this pull request Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI/UX User interface/User experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants